"make disttest" is your friend. use "make disttest"

merlyn on 2002-10-18T13:52:00

A very prolific senior contributor to the CPAN recently updated a module that incorporates XS and C files from another distribution. Said contributor completely tested the new distribution, and published it. It broke for me.

Said contributor forgot to check MANIFEST, which needed a new file added.

make disttest is your friend. Use make disttest.

{grin}


ME!

Matts on 2002-10-18T14:46:47

I own up - it was me.

This is probably the second most common thing I forget when uploading new CPAN modules (the first being to update the Changes file). I'm actually considering changing my "make dist" for a "make cpan" which does the whole "disttest" thing and also "cvs ci" and checks the Changes file for a line representative of this version.

Of course that's all more work I need to do ;-)

The other problem is that "disttest" is a bit broken (at least on 5.6.1 and all versions below it), because it leaves the distro directory lying around, which for some reason when you do "make dist" right after that, will incorporate the entire contents of that directory in your archive. I should probably check if 5.8 still has this bug and submit a patch accordingly, unless this is something intentional.

Re:ME!

brian_d_foy on 2002-10-21T18:50:46

I have not encountered the `make dist` bug that includes old `make disttest` distributions in 5.6.1 or 5.8.0.

I have fixed most of my stupidity problems with my release script. It tests everything and will not let me release something if anything fails or if CVS is not up-to-date. I have been very happy with it the past month even though I need to add a couple of things. :)

Re:ME!

Matts on 2002-10-22T06:48:17

Nice script. Possibly the reason you haven't seen this bug is either because it's fixed in 5.6, or because you make dist before you make disttest.