Indirect object notation is frowned upon

mattk on 2008-09-20T17:32:57

I like to banish it in Vim, with this:

%s/\(new\) \([A-Za-z0-9:]*\)/\2->\1/gc


\1 is frowned upon ;)

fireartist on 2008-09-21T16:43:46

\1 and \2 in the right-hand side of a search-and-replace is frowned up (specifically, it causes a warning under the warnings pragma) - instead use $1 and $2

Re:\1 is frowned upon ;)

Aristotle on 2008-09-21T18:03:45

Did you actually pay attention? He posted a Vim command, not a line of Perl, given away by the initial % and the /c modifier. And, err, Vim has neither $1 nor a warnings pragma.

Re:\1 is frowned upon ;)

fireartist on 2008-09-21T19:47:00

Yes I read that it was for use in vim - but the only vim command I know is ":wq"

No I didn't notice the only 2 characters that makes it not valid perl (though the leading % char could mean anything if it were sort of configuration language)

Though, I can't imagine the OP cares, as I hope the smiley in my original subject line would communicate it as only a light-hearted poke.
And I don't really care, as my comment shows I probably don't use vim.

So, I guess that's a long winded (and hopefully vaguely polite) way of saying "whatever, let's move on"

star?

bart on 2008-09-21T19:32:48

Shouldn't that star after the "class name characters" not actually be a plus? Otherwise, I'm quite sure you'll "fix" too much. You probably still will, for example use of the word "new" in comments.