All the Perl that's Practical to Extract and Report

Date Holidays modules on CPAN (part 2)

jonasbn on 2004-05-13T07:34:14

I have sent a implementation of an extra method to the maintainer (as written in my journal earlier) of Date::Holidays::DK (LTHEGLER). The aim was to try and get the module to be able to share its internal data - the module on CPAN should be updated soon.

The current version of Date::Holidays::DK (0.01) only holds the is_dk_holiday method. So my dk_holidays method returns the complete set of holidays for a given year.

I would very much like for the other Date::Holidays::* (and Date::Japanese::Holidays) modules to implement the same method (I have not started lobbying seriously for this yet).

Today it struck me, that if all the modules in the Date::Holidays::* namespace (and the Japanese one) implement differently named versions, using all of them will result in long programs - and the solution is of course polymorphy.

SO! - I have just mailed the author of Date::Holidays::DK a new patch implementing the following methods by wrapping the existing ones:

  • is_holiday
  • holidays

    Looking forward to hearing what he says :)

    Lobbying you say?

    richardc on 2004-05-13T08:36:02

    I would very much like for the other Date::Holidays::* (and Date::Japanese::Holidays) modules to implement the same method (I have not started lobbying seriously for this yet).

    Or even at all, if you believe my inbox.

    richardc - guilty party for Date::Holidays::UK

    Journal

    jonasbn on 2004-05-13T08:49:31

    I have only lobbied in my journal - I was thinking about what would be the best way to go about this:

    1. Write the authors and ask them to implement?
    2. Write the patches and then write the authors and ask them to accept?
    3. Write an abstract module using Michael Schwerns Class::Virtual and then do 2.
    4. Do nothing and hope for the best

    I am currently working on 3 just for the fun of it - it is pratically done - only docs remain...