Module::Info Patches

jonasbn on 2003-06-03T20:22:35

I got an answer from the author of Module::Info (Mattia Barbon) today. And as I anticipated he is probably going to reject my patches.

It is only the second time I send a patch to somebody and apparently I had the proces of using diff upside down :)

So just for the fun of it I have recreated the pathes (following the advice of Mattia) so I at least could get the hang of using diff properly.

I argued why the patches should be applied, but at the same time I understand Mattia and I respect his decision and that he is the author of Module::Info - and I am thankful that he got back to me with feedback.

Well I learned a lot from the proces - and I will propably make patches to modules again if I get the opportunity, but at the same time I have other things on the drawing board so there is no reason to dwell on this.


patching

inkdroid on 2003-06-03T21:42:22

I seem to remember Schwern offering this up to the highest bidder a few months ago so it could get the attention it deserved. It's mighty cool how it uses B::Utils to parse the opcode tree. I've been meaning to learn more about that for a few months and just haven't found the time somehow. It looks like Mattia has been applying quite a few patches since he took over, so I imagine he has some solid reasons for not applying your patch.

0.20
    - Fixed a warning in module_info (thanks to Nathan Torkington)
    - Corrected number of skipped tests for Perl versions earlier
      thank 5.6.1 (thanks to Mike Fragassi)

0.19  Tue Apr  1 15:45:43 CEST 2003
    + Added package_versions() (patch by Ken Williams).
    - Fixed handling of v-strings in use/require.

0.18  Sat Mar  8 17:44:24 CET 2003
    + Upgraded bundled B::Utils to 0.04 + Schwern patches.
    - Fixed detection of require() statements in non-trivial BEGIN blocks.

0.17  Sun Mar  2 11:01:55 CET 2003
    + Added module_info.
    - Fixed a warning when enumerating packages.

0.16  Wed Jan  1 21:21:31 CET 2003
    - Capture stderr output on MacOS Classic (thanks to Axel Rose for
      the patch)