Woo hoo! Just submitted my first patch to p5p. It appears that shellwords.pl was untainting data from STDIN. Whoops! I also discovered the same problem in Text::ParseWords and tried to email a patch to the author, only to find out that his email is inactive. Humph!
Update: I also submitted a patch for Text::ParseWords and am pleased to announce that both patches will be in 5.8.0 :)
Isn't it fun?
exeunt on 2002-05-21T21:17:36
My
first patch was a doc patch. In fact almost all of my patches have been doc patches, or adding a
$VERSION to a core module. I do have one
script in
/Porting that checks to make sure core modules have a
$VERSION.
Nothing too major, but still fun! Be sure to keep looking for other places to contribute also!
My first patch
jdavidb on 2002-05-21T21:51:40
My first patch (and my only one so far) was the patch that makes sure you can type perl5.6.1 Makefile.PL and it will definitely pick up /path/to/perl5.6.1 instead of /different/path/to/earlier/perl. Believe it or not, with 5.6.0 and earlier, you could do perl5.6.0 Makefile.PL but when you went on to do make && make install you would pick up whatever perl was first in (your PATH + some other dirs), regardless of version or even name. The only way to guarantee the module built with the Perl you wanted was /full/path/to/perl5.xxx Makefile.PL.
All the patch did was invert the position of two nested loops, but since I like to keep my perl separate from the vendor perl I suppose I use this feature every day, so I'm glad I did it.
