... even if some developers are not.</quote>
Hear hear.
http://git.gnome.org/cgit/evolution-data-server/commit/?id=d17494da8ebaba8673a581f256efc8a1d41e1e40
That commit threw out a lot of useful information. When someone comments "I don't know what this fucking function is doing when I call it", the confusion is important.
If you think that having "naughty" words is not okay in your source, fine (thanks, nanny). But please don't remove useful information just to delete the f-word.
Re:Maybe, but that commit is a bad one
vek on 2009-06-11T16:52:14
Agreed. And he was totally inconsistent. Sometimes he'd just replace the naughty word, sometimes he'd remove the entire comment. He even removed an entire debug line because of a naughty word.
Re:Maybe, but that commit is a bad one
jarich on 2009-06-12T00:43:31
I agree with the sentiment of the committer, but I also agree that the commit has thrown out useful information. Removing comments which at least give the reader an understanding of what's the author was thinking, just seems weird. Rewriting them would have been fine (and is what happened for most of them). As an example, the code goes from having the following:
if (pmi == NULL) {
/* Server response is *really* f*****d up,
I guess we just pretend it never happened? */
continue;
}which at least tells the reader why continue is called at that point, to being:
if (pmi == NULL) {
continue;
}Which looks bizarre... why do we continue? Why would pmi be NULL?
... Ned Flanders could write all our code.
Re:If only...
grink on 2009-06-14T02:19:01
my $xyzzy = 1; # Well hidilly-ho, scalareno!Re:If only...
xsawyerx on 2009-06-14T16:59:14
you cracked-a-diddly me up!
:)
It's really too bad that "professional" now means to most people "unoffensive". I wish people would just say "unoffensive" when that's what they mean.
